Implement mge_get_video_size #2890
Open
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for capture on legacy Mupen64, as it needs a way to request the video size in a thread and wgl context-agnostic way
gonetz
reviewed
Jan 8, 2025
| height - Pointer receiving the video height. Can be null. | ||
| Output: none | ||
| ******************************************************************/ | ||
| EXPORT void CALL mge_get_video_size(int32_t* width, int32_t* height); |
There was a problem hiding this comment.
Is it essential to use int32_t? Why not just int?
There was a problem hiding this comment.
It's not essential, but since x64 support for legacy Mupen64 is planned, the Zilmar spec headers have had their types indiscriminately changed to the C++ constant-width ones to avoid miscellaneous annoyances during porting of plugins.
This specific change is free to be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for capture on legacy Mupen64, as it needs a way to request the video size in a thread and wgl context-agnostic way.